From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: mark.d.rustad@intel.com, netdev@vger.kernel.org,
gaofeng@cn.fujitsu.com, eric.dumazet@gmail.com
Subject: Re: [PATCH] net: Statically initialize init_net.dev_base_head
Date: Wed, 18 Jul 2012 13:20:10 -0700 (PDT) [thread overview]
Message-ID: <20120718.132010.1765790775051953381.davem@davemloft.net> (raw)
In-Reply-To: <20120718201149.GB22057@hmsreliant.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Wed, 18 Jul 2012 16:11:49 -0400
> On Wed, Jul 18, 2012 at 12:06:07PM -0700, Mark Rustad wrote:
>> This change eliminates an initialization-order hazard most
>> recently seen when netprio_cgroup is built into the kernel.
>>
>> With thanks to Eric Dumazet for catching a bug.
>>
>> Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
...
> I think dave was going to take John Fastabends patch from earlier today, but
> this works just as well. Long term I'm going to look into delaying
> initzlization for cgroups, as it creates a strange initialization state when you
> have a module_init routine registered.
Neil, any particular preference between John's and Mark's version
of the fix?
next prev parent reply other threads:[~2012-07-18 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 19:06 [PATCH] net: Statically initialize init_net.dev_base_head Mark Rustad
2012-07-18 19:13 ` Eric Dumazet
2012-07-18 20:32 ` David Miller
2012-07-18 20:11 ` Neil Horman
2012-07-18 20:20 ` David Miller [this message]
2012-07-18 20:21 ` Neil Horman
2012-07-18 20:31 ` John Fastabend
2012-07-18 20:32 ` David Miller
2012-07-18 21:56 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718.132010.1765790775051953381.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=mark.d.rustad@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).