From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next V1 1/9] IB/ipoib: Add support for clones / multiple childs on the same partition Date: Wed, 18 Jul 2012 14:36:08 -0700 (PDT) Message-ID: <20120718.143608.2101579052587289420.davem@davemloft.net> References: <1342609202-32427-2-git-send-email-ogerlitz@mellanox.com> <20120718.113850.305478348143779010.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: roland@kernel.org, netdev@vger.kernel.org, ali@mellanox.com, sean.hefty@intel.com, shlomop@mellanox.com, erezsh@mellanox.co.il To: or.gerlitz@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:38744 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753824Ab2GRVgJ (ORCPT ); Wed, 18 Jul 2012 17:36:09 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Or Gerlitz Date: Thu, 19 Jul 2012 00:24:58 +0300 > On Wed, Jul 18, 2012 at 9:38 PM, David Miller wrote: >> From: Or Gerlitz > >>> All sorts of childs are still created/deleted through sysfs, in a >>> similar manner to the way legacy child interfaces are. > >> Network device instantiation of this type is the domain of >> rtnl_link_ops rather than ugly sysfs interfaces. > > Didn't add any **new** sysfs interfaces in this patch. The IPoIB sysfs > entries to create child devices are there from IPoIB's day one, and > we're only extending them a tiny bit. That's extremely unfortunate, having private ways of instantiating networking devices leads to an extremely poor user experience. Would you like to have to train every single user in the case where each and every driver author makes his own unique way of configuring his hardware?