From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: romieu@fr.zoreil.com, hayeswang@realtek.com, netdev@vger.kernel.org
Subject: Re: [RFC] r8169 : why SG / TX checksum are default disabled
Date: Wed, 18 Jul 2012 15:24:05 -0700 (PDT) [thread overview]
Message-ID: <20120718.152405.1083396282134539674.davem@davemloft.net> (raw)
In-Reply-To: <1342649136.2626.3757.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 19 Jul 2012 00:05:36 +0200
> On Wed, 2012-07-18 at 23:44 +0200, Francois Romieu wrote:
>> David Miller <davem@davemloft.net> :
>> [...]
>> > A NETDEV_TX_OK return means we accepted the SKB, it doesn't look like
>> > that's what you are doing in the skb_padto() failure path.
>>
>> ?
>>
>> - skb_padto fails
>> (original skb is implicitely freed)
>> - skb_padto returns error status (!= 0)
>> - rtl8169_tso_csum returns false
>> - start_xmit returns NETDEV_TX_OK.
>>
>> I'll search the missing "!" after some sleep if that's what you are talking
>> about. Otherwise than that, I don't get it.
>>
>
>
> Yes, I believe your patch is fine.
>
> In fact many drivers dont account the error in their stats.
My bad, I forgot that skb_padto() frees the SKB on failure.
next prev parent reply other threads:[~2012-07-18 22:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 22:39 [RFC] r8169 : why SG / TX checksum are default disabled Eric Dumazet
2012-07-17 23:40 ` Francois Romieu
2012-07-18 6:45 ` hayeswang
2012-07-18 16:23 ` David Miller
2012-07-18 20:12 ` Francois Romieu
2012-07-18 20:28 ` David Miller
2012-07-18 21:44 ` Francois Romieu
2012-07-18 22:05 ` Eric Dumazet
2012-07-18 22:24 ` David Miller [this message]
2012-07-20 7:14 ` hayeswang
2012-07-20 10:08 ` Francois Romieu
2012-07-20 16:01 ` hayeswang
2012-07-20 16:28 ` David Miller
2012-07-20 21:01 ` Francois Romieu
2012-07-24 6:34 ` hayeswang
2012-07-24 6:59 ` David Miller
2012-07-25 2:10 ` hayeswang
2012-07-20 16:17 ` David Miller
2012-07-20 2:11 ` hayeswang
2012-07-18 8:55 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718.152405.1083396282134539674.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).