From: David Miller <davem@davemloft.net>
To: cooldavid@cooldavid.org
Cc: lekensteyn@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] jme: netpoll support
Date: Wed, 18 Jul 2012 20:24:31 -0700 (PDT) [thread overview]
Message-ID: <20120718.202431.2078849403941565725.davem@davemloft.net> (raw)
In-Reply-To: <20120719015637.M13815@cooldavid.org>
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Thu, 19 Jul 2012 10:00:10 +0800
> On Wed, 18 Jul 2012 09:45:24 -0700 (PDT), David Miller wrote
>> From: Lekensteyn <lekensteyn@gmail.com>
>> Date: Tue, 17 Jul 2012 18:29:34 +0200
>>
>> > From: Peter Wu <lekensteyn@gmail.com>
>> >
>> > This patch adds the netpoll function to support netconsole. Tested and works
>> > fine on my "JMC250 PCI Express Gigabit Ethernet Controller" (PCI ID 0250).
>> >
>> > Signed-off-by: Peter Wu <lekensteyn@gmail.com>
>>
>> Applied to net-next
>>
>> I really wonder if this driver works on SMP systems at all.
> Hi davem:
>
> I wrote/tested this driver on SMP system at very beginning.
> In face some of the design was aimed for SMP systems.
> Is there any obvious bug or something I should be aware of?
Well, you do no locking in your IRQ handler.
So how can you be sure in jme_free_irq() during jme_close() that the
handler is not running on some cpu somewhere?
That's why drivers like drivers/net/ethernet/broadcom/tg3.c have
a function like tg3_irq_quiesce(), to guarentee that no code path
is executing in the interrupt handler.
next prev parent reply other threads:[~2012-07-19 3:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 16:29 [PATCH] jme: netpoll support Lekensteyn
2012-07-18 16:45 ` David Miller
2012-07-19 2:00 ` Guo-Fu Tseng
2012-07-19 3:24 ` David Miller [this message]
2012-07-19 4:08 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718.202431.2078849403941565725.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cooldavid@cooldavid.org \
--cc=lekensteyn@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).