From: David Miller <davem@davemloft.net>
To: netdev@vger.kernel.org
Subject: Re: [PATCH 09/15] ipv4: Cache output routes in fib_info nexthops.
Date: Thu, 19 Jul 2012 08:52:29 -0700 (PDT) [thread overview]
Message-ID: <20120719.085229.2014129813204637207.davem@davemloft.net> (raw)
In-Reply-To: <20120718.112404.1910372180742347127.davem@davemloft.net>
In a dream I found a bug in this patch and the next one.
When we fetch a cached route from the FIB info, we have to
check if it has been invalidated by a PMTU event or similar.
And if so, cmpxchg() it with NULL and release it, so we
can build and install a new cached route there.
I'll fix this up when I integrate everyone's feedback later
today.
prev parent reply other threads:[~2012-07-19 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 18:24 [PATCH 09/15] ipv4: Cache output routes in fib_info nexthops David Miller
2012-07-18 20:34 ` Eric Dumazet
2012-07-18 20:36 ` David Miller
2012-07-18 20:40 ` Eric Dumazet
2012-07-18 20:49 ` David Miller
2012-07-19 11:38 ` Steffen Klassert
2012-07-19 15:39 ` David Miller
2012-07-19 15:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719.085229.2014129813204637207.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).