From: David Miller <davem@davemloft.net>
To: christian.riesch@omicron.at
Cc: netdev@vger.kernel.org, allan@asix.com.tw, kernel@teksavvy.com,
grundler@chromium.org
Subject: Re: [PATCH net-next 1/2] asix: Rework reading from EEPROM
Date: Thu, 19 Jul 2012 10:50:25 -0700 (PDT) [thread overview]
Message-ID: <20120719.105025.1954172029358314227.davem@davemloft.net> (raw)
In-Reply-To: <1342693387-17945-1-git-send-email-christian.riesch@omicron.at>
From: Christian Riesch <christian.riesch@omicron.at>
Date: Thu, 19 Jul 2012 12:23:06 +0200
> The current code for reading the EEPROM via ethtool in the asix
> driver has a few issues. It cannot handle odd length values
> (accesses must be aligned at 16 bit boundaries) and interprets the
> offset provided by ethtool as 16 bit word offset instead as byte offset.
>
> The new code for asix_get_eeprom() introduced by this patch is
> modeled after the code in
> drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.c
> and provides read access to the entire EEPROM with arbitrary
> offsets and lengths.
>
> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
Applied.
prev parent reply other threads:[~2012-07-19 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 10:23 [PATCH net-next 1/2] asix: Rework reading from EEPROM Christian Riesch
2012-07-19 10:23 ` [PATCH net-next 2/2] asix: Add support for programming the EEPROM Christian Riesch
2012-07-19 17:50 ` David Miller
2012-07-19 17:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719.105025.1954172029358314227.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allan@asix.com.tw \
--cc=christian.riesch@omicron.at \
--cc=grundler@chromium.org \
--cc=kernel@teksavvy.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).