From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, therbert@google.com, wsommerfeld@google.com
Subject: Re: [PATCH net-next v2] ipv4: tcp: remove per net tcp_sock
Date: Thu, 19 Jul 2012 10:51:56 -0700 (PDT) [thread overview]
Message-ID: <20120719.105156.756282805219314369.davem@davemloft.net> (raw)
In-Reply-To: <1342720197.2626.4624.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 19 Jul 2012 19:49:57 +0200
> On Thu, 2012-07-19 at 10:36 -0700, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Thu, 19 Jul 2012 19:34:03 +0200
>>
>> > v2 : move unicast_sock out of ip_send_unicast_reply() body
>> > init sk_refcnt to 1, in case some driver get/put a reference on
>> > socket.
>>
>> The compiler seems much happier with this, applied, thanks Eric :-)
>
> Maybe I should install your compiler ;) What is the version you
> currently use ?
On x86-64 I use:
[davem@dokdo net-next]$ gcc --version
gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
and on sparc64 I use gcc-4.7.1 vanilla.
next prev parent reply other threads:[~2012-07-19 17:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 17:34 [PATCH net-next v2] ipv4: tcp: remove per net tcp_sock Eric Dumazet
2012-07-19 17:36 ` David Miller
2012-07-19 17:49 ` Eric Dumazet
2012-07-19 17:51 ` David Miller [this message]
2012-07-21 8:00 ` Hiroaki SHIMODA
2012-07-21 8:28 ` Eric Dumazet
2012-07-22 19:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719.105156.756282805219314369.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=wsommerfeld@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox