netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: chenhui.zhao@freescale.com
Cc: netdev@vger.kernel.org, scottwood@freescale.com,
	linux-kernel@vger.kernel.org, leoli@freescale.com
Subject: Re: [PATCH] gianfar: add support for wake-on-packet
Date: Fri, 20 Jul 2012 11:22:13 -0700 (PDT)	[thread overview]
Message-ID: <20120720.112213.1696121870344034064.davem@davemloft.net> (raw)
In-Reply-To: <1342788723-27703-1-git-send-email-chenhui.zhao@freescale.com>

From: Zhao Chenhui <chenhui.zhao@freescale.com>
Date: Fri, 20 Jul 2012 20:52:03 +0800

> Note: The local ip/mac address is the ethernet primary IP/MAC address of
> the station. Do not support multiple IP/MAC addresses.

I'm not applying this.

There is no such concept of "primary IP address" for interfaces,
just picking the first interface address you find is completel
bogus.

Someone might add 100 IP addresses, then the one that's "primary",
and vice versa.

      reply	other threads:[~2012-07-20 18:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 12:52 [PATCH] gianfar: add support for wake-on-packet Zhao Chenhui
2012-07-20 18:22 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120720.112213.1696121870344034064.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=chenhui.zhao@freescale.com \
    --cc=leoli@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).