From: David Miller <davem@davemloft.net>
To: ja@ssi.bg
Cc: netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH 14/16] ipv4: Kill rt->rt_oif
Date: Fri, 20 Jul 2012 13:31:15 -0700 (PDT) [thread overview]
Message-ID: <20120720.133115.1828569805175844233.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1207200219010.5516@ja.ssi.bg>
From: Julian Anastasov <ja@ssi.bg>
Date: Fri, 20 Jul 2012 04:10:12 +0300 (EEST)
>> @@ -1795,7 +1795,6 @@ static struct mr_table *ipmr_rt_fib_lookup(struct net *net, struct sk_buff *skb)
>> .daddr = iph->daddr,
>> .saddr = iph->saddr,
>> .flowi4_tos = RT_TOS(iph->tos),
>> - .flowi4_oif = rt->rt_oif,
>> .flowi4_iif = rt->rt_iif,
>> .flowi4_mark = skb->mark,
>
> But it was wrong at first place to use rt_iif
> here. May be we should provide devices to "mrule" just
> like we do for "rule", with the only difference that
> oif now is possible to match outdev instead of preferred
> device, i.e. oif is always set for output routes.
>
> .flowi4_oif = rt_is_output_route(rt) ?
> skb->dev->ifindex : 0,
> .flowi4_iif = rt_is_output_route(rt) ?
> net->loopback_dev->ifindex :
> skb->dev->ifindex;
Ok.
> Let me know if patch is needed
I'll take care of it myself today, thanks.
next prev parent reply other threads:[~2012-07-20 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 21:36 [PATCH 14/16] ipv4: Kill rt->rt_oif David Miller
2012-07-20 1:10 ` Julian Anastasov
2012-07-20 20:31 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-20 21:26 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720.133115.1828569805175844233.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).