From: David Miller <davem@davemloft.net>
To: ja@ssi.bg
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH RFC] tcp: use seqlock for all cached tcp_metrics
Date: Sun, 22 Jul 2012 12:32:46 -0700 (PDT) [thread overview]
Message-ID: <20120722.123246.864281319907290494.davem@davemloft.net> (raw)
In-Reply-To: <1342950268-2380-1-git-send-email-ja@ssi.bg>
From: Julian Anastasov <ja@ssi.bg>
Date: Sun, 22 Jul 2012 12:44:28 +0300
> The ability to reclaim existing cache entries
> requires metrics to be accessed with additional seqlock.
> fastopen_cache tried to provide such locking for its values
> but there is always the risk to access reclaimed entry.
I basically claim that accidental use of reclaimed entries
is completely harmless for everything other than fastopen.
Therefore I do not advocate adding the new overhead and complexity for
the non-fastopen cases. It should be a completely free, lockless, and
synchornization free cache. If we read crap metrics, so be it, maybe
the network dynamics changed to the same amount, and we would never
know the different. Therefore, it doesn't really matter if we read
crap values for these measurements.
Thanks.
next prev parent reply other threads:[~2012-07-22 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 9:44 [PATCH RFC] tcp: use seqlock for all cached tcp_metrics Julian Anastasov
2012-07-22 19:32 ` David Miller [this message]
2012-07-22 20:34 ` Julian Anastasov
2012-07-22 21:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120722.123246.864281319907290494.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).