* [PATCH] USB: plusb: Add support for PL-2501
@ 2012-07-23 11:44 kyak
2012-07-23 20:08 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: kyak @ 2012-07-23 11:44 UTC (permalink / raw)
To: linux-kernel; +Cc: Sergei Shtylyov, linux-usb, netdev, Greg Kroah-Hartman
From: Mikhail Peselnik <peselnik@gmail.com>
This patch adds support for PL-2501 by adding the appropriate USB
ID's. This chip is used in several USB 'Easy Trasfer' Cables.
Signed-off-by: Mikhail Peselnik <peselnik@gmail.com>
Tested-by: Mikhail Peselnik <peselnik@gmail.com>
---
Now with proper sign-offs and right people in cc and unwrapped lines.
plusb driver (drivers/net/usb/plusb.c) doesn't recognize PL2501 chip.
Since PL2501 uses the same code as PL2301/PL2302 (PL2501 works in
compatibility mode with PL2301/PL2302), the fix is trivial and
attached as a patch.
Just to note: the patch is not mine, it can be found here and there on
Internet.
I've tested the patch and it works great.
Thank you.
--- linux-3.5/drivers/net/usb/plusb.c.orig 2012-07-22 21:06:41.905802795 +0400
+++ linux-3.5/drivers/net/usb/plusb.c 2012-07-22 21:07:00.345552404 +0400
@@ -107,7 +107,7 @@ static int pl_reset(struct usbnet *dev)
}
static const struct driver_info prolific_info = {
- .description = "Prolific PL-2301/PL-2302/PL-25A1",
+ .description = "Prolific PL-2301/PL-2302/PL-25A1/PL-2501",
.flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT,
/* some PL-2302 versions seem to fail usb_set_interface() */
.reset = pl_reset,
@@ -139,6 +139,9 @@ static const struct usb_device_id produc
}, {
USB_DEVICE(0x050d, 0x258a), /* Belkin F5U258/F5U279 (PL-25A1) */
.driver_info = (unsigned long) &prolific_info,
+}, {
+ USB_DEVICE(0x067b, 0x2501), /* PL-2501 */
+ .driver_info = (unsigned long) &prolific_info,
},
{ }, // END
@@ -158,5 +161,5 @@ static struct usb_driver plusb_driver =
module_usb_driver(plusb_driver);
MODULE_AUTHOR("David Brownell");
-MODULE_DESCRIPTION("Prolific PL-2301/2302/25A1 USB Host to Host Link Driver");
+MODULE_DESCRIPTION("Prolific PL-2301/2302/25A1/2501 USB Host to Host Link Driver");
MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] USB: plusb: Add support for PL-2501
2012-07-23 11:44 [PATCH] USB: plusb: Add support for PL-2501 kyak
@ 2012-07-23 20:08 ` David Miller
2012-07-24 5:39 ` kyak
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2012-07-23 20:08 UTC (permalink / raw)
To: bas; +Cc: linux-kernel, sshtylyov, linux-usb, netdev, greg
From: kyak <bas@bmail.ru>
Date: Mon, 23 Jul 2012 15:44:11 +0400 (MSK)
> From: Mikhail Peselnik <peselnik@gmail.com>
>
> This patch adds support for PL-2501 by adding the appropriate USB
> ID's. This chip is used in several USB 'Easy Trasfer' Cables.
>
> Signed-off-by: Mikhail Peselnik <peselnik@gmail.com>
> Tested-by: Mikhail Peselnik <peselnik@gmail.com>
This does not apply cleanly to my net-next tree at all.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: plusb: Add support for PL-2501
2012-07-23 20:08 ` David Miller
@ 2012-07-24 5:39 ` kyak
2012-07-24 6:57 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: kyak @ 2012-07-24 5:39 UTC (permalink / raw)
To: David Miller; +Cc: bas, linux-kernel, sshtylyov, linux-usb, netdev, greg
This patch was created against linux-3.5, but it applies perfectly
against net-next tree, i just checked..
I'm sorry for not being able to submit the correct patch from the first
attempt (and not even from the third attempt). Could you be more specific
about "doesn't apply cleanly at all"? By the way, i'm perfectly fine if
you just make this trivial change by yourself and take the credit, because
our exchange of e-mails has become 20 times bigger than the patch
itself. Probably sending another version of this patch from my side would
be just another waste of (your) time.
On Mon, 23 Jul 2012, David Miller wrote:
> From: kyak <bas@bmail.ru>
> Date: Mon, 23 Jul 2012 15:44:11 +0400 (MSK)
>
>> From: Mikhail Peselnik <peselnik@gmail.com>
>>
>> This patch adds support for PL-2501 by adding the appropriate USB
>> ID's. This chip is used in several USB 'Easy Trasfer' Cables.
>>
>> Signed-off-by: Mikhail Peselnik <peselnik@gmail.com>
>> Tested-by: Mikhail Peselnik <peselnik@gmail.com>
>
> This does not apply cleanly to my net-next tree at all.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: plusb: Add support for PL-2501
2012-07-24 5:39 ` kyak
@ 2012-07-24 6:57 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2012-07-24 6:57 UTC (permalink / raw)
To: bas; +Cc: linux-kernel, sshtylyov, linux-usb, netdev, greg
From: kyak <bas@bmail.ru>
Date: Tue, 24 Jul 2012 09:39:40 +0400 (MSK)
> This patch was created against linux-3.5, but it applies perfectly
> against net-next tree, i just checked..
>
> I'm sorry for not being able to submit the correct patch from the
> first attempt (and not even from the third attempt). Could you be more
> specific about "doesn't apply cleanly at all"?
"git am your_patch" fails.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] USB: plusb: Add support for PL-2501
@ 2012-07-22 17:42 kyak
2012-07-23 10:25 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: kyak @ 2012-07-22 17:42 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman, linux-usb, netdev
From: Mikhail Peselnik <peselnik@gmail.com>
This patch adds support for PL-2501 by adding the appropriate USB
ID's. This chip is used in several USB 'Easy Trasfer' Cables.
Signed-off-by: Mikhail Peselnik <peselnik@gmail.com>
Tested-by: Mikhail Peselnik <peselnik@gmail.com>
---
Now with proper sign-offs and right people in cc.
plusb driver (drivers/net/usb/plusb.c) doesn't recognize PL2501 chip.
Since PL2501 uses the same code as PL2301/PL2302 (PL2501 works in
compatibility mode with PL2301/PL2302), the fix is trivial and
attached as a patch.
Just to note: the patch is not mine, it can be found here and there on
Internet.
I've tested the patch and it works great.
Thank you.
--- linux-3.5/drivers/net/usb/plusb.c.orig 2012-07-22
21:06:41.905802795 +0400
+++ linux-3.5/drivers/net/usb/plusb.c 2012-07-22 21:07:00.345552404 +0400
@@ -107,7 +107,7 @@ static int pl_reset(struct usbnet *dev)
}
static const struct driver_info prolific_info = {
- .description = "Prolific PL-2301/PL-2302/PL-25A1",
+ .description = "Prolific PL-2301/PL-2302/PL-25A1/PL-2501",
.flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT,
/* some PL-2302 versions seem to fail usb_set_interface() */
.reset = pl_reset,
@@ -139,6 +139,9 @@ static const struct usb_device_id produc
}, {
USB_DEVICE(0x050d, 0x258a), /* Belkin F5U258/F5U279 (PL-25A1) */
.driver_info = (unsigned long) &prolific_info,
+}, {
+ USB_DEVICE(0x067b, 0x2501), /* PL-2501 */
+ .driver_info = (unsigned long) &prolific_info,
},
{ }, // END
@@ -158,5 +161,5 @@ static struct usb_driver plusb_driver =
module_usb_driver(plusb_driver);
MODULE_AUTHOR("David Brownell");
-MODULE_DESCRIPTION("Prolific PL-2301/2302/25A1 USB Host to Host Link Driver");
+MODULE_DESCRIPTION("Prolific PL-2301/2302/25A1/2501 USB Host to Host
Link Driver");
MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] USB: plusb: Add support for PL-2501
2012-07-22 17:42 kyak
@ 2012-07-23 10:25 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2012-07-23 10:25 UTC (permalink / raw)
To: kyak
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Greg Kroah-Hartman,
linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA
Hello.
On 22-07-2012 21:42, kyak wrote:
> From: Mikhail Peselnik <peselnik-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> This patch adds support for PL-2501 by adding the appropriate USB
> ID's. This chip is used in several USB 'Easy Trasfer' Cables.
> Signed-off-by: Mikhail Peselnik <peselnik-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Tested-by: Mikhail Peselnik <peselnik-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> Now with proper sign-offs and right people in cc.
> plusb driver (drivers/net/usb/plusb.c) doesn't recognize PL2501 chip.
> Since PL2501 uses the same code as PL2301/PL2302 (PL2501 works in
> compatibility mode with PL2301/PL2302), the fix is trivial and
> attached as a patch.
> Just to note: the patch is not mine, it can be found here and there on
> Internet.
> I've tested the patch and it works great.
> Thank you.
> --- linux-3.5/drivers/net/usb/plusb.c.orig 2012-07-22
> 21:06:41.905802795 +0400
> +++ linux-3.5/drivers/net/usb/plusb.c 2012-07-22 21:07:00.345552404 +0400
[...]
> @@ -158,5 +161,5 @@ static struct usb_driver plusb_driver =
> module_usb_driver(plusb_driver);
>
> MODULE_AUTHOR("David Brownell");
> -MODULE_DESCRIPTION("Prolific PL-2301/2302/25A1 USB Host to Host Link Driver");
> +MODULE_DESCRIPTION("Prolific PL-2301/2302/25A1/2501 USB Host to Host
> Link Driver");
Your patch is line wrapped. Seeems easy to fix though...
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-24 6:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-23 11:44 [PATCH] USB: plusb: Add support for PL-2501 kyak
2012-07-23 20:08 ` David Miller
2012-07-24 5:39 ` kyak
2012-07-24 6:57 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-07-22 17:42 kyak
2012-07-23 10:25 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).