From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] tcp: early_demux fixes
Date: Tue, 24 Jul 2012 13:56:46 -0700 (PDT) [thread overview]
Message-ID: <20120724.135646.458225356444764082.davem@davemloft.net> (raw)
In-Reply-To: <1343128771.2626.11059.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 24 Jul 2012 13:19:31 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> 1) Remove a non needed pskb_may_pull() in tcp_v4_early_demux()
> and fix a potential bug if skb->head was reallocated
> (iph & th pointers were not reloaded)
>
> TCP stack will pull/check headers anyway.
>
> 2) must reload iph in ip_rcv_finish() after early_demux()
> call since skb->head might have changed.
>
> 3) skb->dev->ifindex can be now replaced by skb->skb_iif
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2012-07-24 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 11:19 [PATCH v2 net-next] tcp: early_demux fixes Eric Dumazet
2012-07-24 20:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120724.135646.458225356444764082.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).