From: David Miller <davem@davemloft.net>
To: nicolas.2p.debian@gmail.com
Cc: ja@ssi.bg, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ipv4: Change rt->rt_iif encoding.
Date: Tue, 24 Jul 2012 15:18:01 -0700 (PDT) [thread overview]
Message-ID: <20120724.151801.1576915988616906722.davem@davemloft.net> (raw)
In-Reply-To: <500F1E23.7090803@gmail.com>
From: Nicolas de Pesloüan <nicolas.2p.debian@gmail.com>
Date: Wed, 25 Jul 2012 00:13:55 +0200
> - From the af_packet point of view, is was "the real original device
> - that received the packet".
>
> As bonding don't use orig_dev anymore, the remaining meaning should
> logically be "the real original device that received the packet". But
> as __netif_receive_skb() is recursively called in many cases, setting
> orig_dev to something new every time, this meaning is probably mostly
> inconsistent. As such, it sounds appropriate to remove orig_dev and
> use skb_iif instead.
I don't think we can, otherwise people who set po->origdev will no
longer get what they expect.
For the simpler cases of bonding and VLANs, it does currently behaved
as expected.
That's why I left it alone.
next prev parent reply other threads:[~2012-07-24 22:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 21:07 [PATCH 2/2] ipv4: Change rt->rt_iif encoding David Miller
2012-07-23 22:22 ` David Miller
2012-07-23 23:04 ` David Miller
2012-07-23 23:11 ` Julian Anastasov
2012-07-23 23:05 ` David Miller
2012-07-23 23:14 ` David Miller
2012-07-24 0:24 ` Julian Anastasov
2012-07-24 0:43 ` David Miller
2012-07-24 7:41 ` Julian Anastasov
2012-07-24 22:13 ` Nicolas de Pesloüan
2012-07-24 22:18 ` David Miller [this message]
2012-07-24 22:25 ` Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120724.151801.1576915988616906722.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).