From: Josh Boyer <jwboyer@redhat.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "Eric Dumazet" <eric.dumazet@gmail.com>,
"David Miller" <davem@davemloft.net>,
hayeswang@realtek.com, netdev@vger.kernel.org,
"Alex Villacís Lasso" <a_villacis@palosanto.com>,
"Tom Herbert" <therbert@google.com>
Subject: Re: [PATCH] r8169: revert "add byte queue limit support".
Date: Tue, 24 Jul 2012 07:11:21 -0400 [thread overview]
Message-ID: <20120724111120.GA14840@zod.bos.redhat.com> (raw)
In-Reply-To: <20120724053811.GA12053@electric-eye.fr.zoreil.com>
On Tue, Jul 24, 2012 at 07:38:11AM +0200, Francois Romieu wrote:
> Eric Dumazet <eric.dumazet@gmail.com> :
> > On Mon, 2012-07-23 at 22:55 +0200, Francois Romieu wrote:
> > > This reverts commit 036dafa28da1e2565a8529de2ae663c37b7a0060.
> [...]
> > bisection is not always the right way to qualify a problem.
>
> I know. At some point I switch from "I could search more" to "users situation
> will improve in a definite timeframe".
>
> > BQL in itself had some fixes coming _after_ commit 036dafa28da1e2565
>
> Thanks.
>
> They are in stable as of 3.4.5:
>
> commit 4f4bdaeb40df95499c1ee7ea3fbca9d76174a59e
> Author: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
> AuthorDate: Wed May 30 12:25:37 2012 +0000
> Commit: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CommitDate: Mon Jul 16 09:03:43 2012 -0700
>
> bql: Avoid possible inconsistent calculation.
>
> [ Upstream commit 914bec1011a25f65cdc94988a6f974bfb9a3c10d ]
> [...]
> commit 1414a53d956340ca8b1b27e05ab94ba63e82ed97
> Author: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
> AuthorDate: Wed May 30 12:25:19 2012 +0000
> Commit: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CommitDate: Mon Jul 16 09:03:43 2012 -0700
>
> bql: Avoid unneeded limit decrement.
>
> I have obviously not directed users at them and I do not see any
> of the victims using a non -stable / -vendor or recent enough
> kernel to test this patch since the issue has been reported.
>
> They are both worth testing.
Fedora has 3.4.5 in the F16 updates-testing repo. F17 is already on
3.4.6 in stable updates. Users should be able to use those kernels for
testing. F16 will be getting 3.4.6 submitted this morning for
updates-testing.
josh
next prev parent reply other threads:[~2012-07-24 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 20:55 [PATCH] r8169: revert "add byte queue limit support" Francois Romieu
2012-07-24 1:27 ` David Miller
2012-07-24 5:06 ` Eric Dumazet
2012-07-24 5:09 ` Eric Dumazet
2012-07-24 5:38 ` Francois Romieu
2012-07-24 11:11 ` Josh Boyer [this message]
2012-07-27 3:36 ` Stefan Lippers-Hollmann
2012-07-27 5:27 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120724111120.GA14840@zod.bos.redhat.com \
--to=jwboyer@redhat.com \
--cc=a_villacis@palosanto.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).