From: David Miller <davem@davemloft.net>
To: hauke@hauke-m.de
Cc: torvalds@linux-foundation.org, linville@tuxdriver.com,
brcm80211-dev-list@broadcom.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
seth.forshee@canonical.com, pieterpg@broadcom.com,
brudley@broadcom.com, arend@broadcom.com, zajec5@gmail.com
Subject: Re: [PATCH] bcma: fix regression in pmu workaround reg masks
Date: Thu, 26 Jul 2012 03:06:59 -0700 (PDT) [thread overview]
Message-ID: <20120726.030659.2063192496743861099.davem@davemloft.net> (raw)
In-Reply-To: <1343294151-5691-1-git-send-email-hauke@hauke-m.de>
From: Hauke Mehrtens <hauke@hauke-m.de>
Date: Thu, 26 Jul 2012 11:15:51 +0200
> This fixes a regression introduced in:
> commit b9562545ef0b13c0440ccd8d6dd4111fb77cb17a
> Author: Hauke Mehrtens <hauke@hauke-m.de>
> Date: Sat Jun 30 01:44:41 2012 +0200
>
> bcma: complete workaround for BCMA43224 and BCM4313
>
> The regression broke reading of the sprom from the chip and seamed to
> cause a change of the pci id on a BCMA43224 device so that it is
> rejected by brcmsmac. If this problem occurred, after applying this
> patch, a cold boot is needed to make the device work again.
>
> In the original patch the workaround set the intended bits in the chip
> common core chip control registers, but the patch also unset all the
> other bits in that register, because of a wrong mask. The original
> patch was based on code from brcmsmac and there was an additional
> inversing of the mask in the code setting these regs which was missing
> here. Now the regs are set like brcmsmac did it before.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Tested-by: Seth Forshee <seth.forshee@canonical.com>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2012-07-26 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 9:15 [PATCH] bcma: fix regression in pmu workaround reg masks Hauke Mehrtens
2012-07-26 10:06 ` David Miller [this message]
2012-07-26 21:07 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726.030659.2063192496743861099.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pieterpg@broadcom.com \
--cc=seth.forshee@canonical.com \
--cc=torvalds@linux-foundation.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox