* [PATCH 1/3] pch_gbe: fix transmit watchdog timeout
@ 2012-07-26 15:59 Andy Cress
2012-07-26 21:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andy Cress @ 2012-07-26 15:59 UTC (permalink / raw)
To: netdev
An extended ping test with 6 vlans resulted in a driver oops with a
netdev transmit timeout.
Fix WATCHDOG_TIMEOUT to be more like e1000e at 5 * HZ, to avoid
unnecessary transmit timeouts.
Signed-off-by: Andy Cress <andy.cress@us.kontron.com>
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index 4c04843..a746064 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -35,7 +35,7 @@ const char pch_driver_version[] = DRV_VERSION;
#define DSC_INIT16 0xC000
#define PCH_GBE_DMA_ALIGN 0
#define PCH_GBE_DMA_PADDING 2
-#define PCH_GBE_WATCHDOG_PERIOD (1 * HZ) /* watchdog time */
+#define PCH_GBE_WATCHDOG_PERIOD (5 * HZ) /* watchdog time */
#define PCH_GBE_COPYBREAK_DEFAULT 256
#define PCH_GBE_PCI_BAR 1
#define PCH_GBE_RESERVE_MEMORY 0x200000 /* 2MB */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] pch_gbe: fix transmit watchdog timeout
2012-07-26 15:59 [PATCH 1/3] pch_gbe: fix transmit watchdog timeout Andy Cress
@ 2012-07-26 21:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-07-26 21:30 UTC (permalink / raw)
To: andycress; +Cc: netdev
From: Andy Cress <andycress@gmail.com>
Date: Thu, 26 Jul 2012 11:59:07 -0400
>
> An extended ping test with 6 vlans resulted in a driver oops with a
> netdev transmit timeout.
> Fix WATCHDOG_TIMEOUT to be more like e1000e at 5 * HZ, to avoid
> unnecessary transmit timeouts.
>
> Signed-off-by: Andy Cress <andy.cress@us.kontron.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-26 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-26 15:59 [PATCH 1/3] pch_gbe: fix transmit watchdog timeout Andy Cress
2012-07-26 21:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).