From: David Miller <davem@davemloft.net>
To: andycress@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] pch_gbe: add extra clean tx
Date: Thu, 26 Jul 2012 14:31:36 -0700 (PDT) [thread overview]
Message-ID: <20120726.143136.495599687146212368.davem@davemloft.net> (raw)
In-Reply-To: <20120726160011.GC10287@telcoserv5>
From: Andy Cress <andycress@gmail.com>
Date: Thu, 26 Jul 2012 12:00:11 -0400
> This adds extra cleaning to the pch_gbe_clean_tx routine to avoid
> transmit timeouts on some BCM PHYs that have different timing.
> Also update the DRV_VERSION to 1.01, and show it.
>
> Signed-off-by: Andy Cress <andy.cress@us.kontron.com>
Applied.
....
> + if (unused < 8) { /* tx queue nearly full */
> + pr_debug("clean_tx: transmit queue warning (%x,%x) unused=%d\n",
> + tx_ring->next_to_clean,tx_ring->next_to_use,unused);
> + }
> +
^^^^^^^^^^
Trailing whitespace.
> + for (j = 0; j < PCH_GBE_TX_WEIGHT; j++)
^^^
Likewise.
Clean this crap up before submitting patches formally, so I don't have
to.
next prev parent reply other threads:[~2012-07-26 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 16:00 [PATCH 2/3] pch_gbe: add extra clean tx Andy Cress
2012-07-26 21:31 ` David Miller [this message]
2012-07-27 13:21 ` Andy Cress
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726.143136.495599687146212368.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andycress@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).