From: David Miller <davem@davemloft.net>
To: jbenc@redhat.com
Cc: netdev@vger.kernel.org, makc@redhat.com
Subject: Re: [PATCH] net: fix rtnetlink IFF_PROMISC and IFF_ALLMULTI handling
Date: Fri, 27 Jul 2012 13:46:50 -0700 (PDT) [thread overview]
Message-ID: <20120727.134650.366843201370833087.davem@davemloft.net> (raw)
In-Reply-To: <20120727145822.7efd10d4@griffin>
From: Jiri Benc <jbenc@redhat.com>
Date: Fri, 27 Jul 2012 14:58:22 +0200
> When device flags are set using rtnetlink, IFF_PROMISC and IFF_ALLMULTI
> flags are handled specially. Function dev_change_flags sets IFF_PROMISC and
> IFF_ALLMULTI bits in dev->gflags according to the passed value but
> do_setlink passes a result of rtnl_dev_combine_flags which takes those bits
> from dev->flags.
>
> This can be easily trigerred by doing:
>
> tcpdump -i eth0 &
> ip l s up eth0
>
> ip sets IFF_UP flag in ifi_flags and ifi_change, which is combined with
> IFF_PROMISC by rtnl_dev_combine_flags, causing __dev_change_flags to set
> IFF_PROMISC in gflags.
>
> Reported-by: Max Matveev <makc@redhat.com>
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
Applied.
prev parent reply other threads:[~2012-07-27 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 12:58 [PATCH] net: fix rtnetlink IFF_PROMISC and IFF_ALLMULTI handling Jiri Benc
2012-07-27 20:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120727.134650.366843201370833087.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=makc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).