* [PATCH] Revert "openvswitch: potential NULL deref in sample()"
@ 2012-07-27 20:19 Jesse Gross
2012-07-27 20:47 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jesse Gross @ 2012-07-27 20:19 UTC (permalink / raw)
To: David Miller
Cc: dev-yBygre7rU0TnMu66kgdUjQ, netdev-u79uwXL29TY76Z2rM5mHXA,
Dan Carpenter
This reverts commit 5b3e7e6cb5771bedda51cdb6f715d1da8cd9e644.
The problem that the original commit was attempting to fix can
never happen in practice because validation is done one a per-flow
basis rather than a per-packet basis. Adding additional checks at
runtime is unnecessary and inconsistent with the rest of the code.
CC: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Jesse Gross <jesse-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
---
net/openvswitch/actions.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
index 320fa0e..f3f96ba 100644
--- a/net/openvswitch/actions.c
+++ b/net/openvswitch/actions.c
@@ -325,9 +325,6 @@ static int sample(struct datapath *dp, struct sk_buff *skb,
}
}
- if (!acts_list)
- return 0;
-
return do_execute_actions(dp, skb, nla_data(acts_list),
nla_len(acts_list), true);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Revert "openvswitch: potential NULL deref in sample()"
2012-07-27 20:19 [PATCH] Revert "openvswitch: potential NULL deref in sample()" Jesse Gross
@ 2012-07-27 20:47 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-07-27 20:47 UTC (permalink / raw)
To: jesse; +Cc: netdev, dev, dan.carpenter
From: Jesse Gross <jesse@nicira.com>
Date: Fri, 27 Jul 2012 13:19:40 -0700
> This reverts commit 5b3e7e6cb5771bedda51cdb6f715d1da8cd9e644.
>
> The problem that the original commit was attempting to fix can
> never happen in practice because validation is done one a per-flow
> basis rather than a per-packet basis. Adding additional checks at
> runtime is unnecessary and inconsistent with the rest of the code.
>
> CC: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Jesse Gross <jesse@nicira.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-27 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-27 20:19 [PATCH] Revert "openvswitch: potential NULL deref in sample()" Jesse Gross
2012-07-27 20:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).