* [PATCH] bnx2x: remove cast around the kmalloc in bnx2x_prev_mark_path
@ 2012-07-29 13:19 Devendra Naga
2012-07-30 4:50 ` Eilon Greenstein
2012-07-30 6:19 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Devendra Naga @ 2012-07-29 13:19 UTC (permalink / raw)
To: Eilon Greenstein, netdev; +Cc: Devendra Naga
casting the void pointer is redundant (Documentation/CodingStyle)
Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 9aaf863..dd451c3 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -9360,8 +9360,7 @@ static int __devinit bnx2x_prev_mark_path(struct bnx2x *bp)
struct bnx2x_prev_path_list *tmp_list;
int rc;
- tmp_list = (struct bnx2x_prev_path_list *)
- kmalloc(sizeof(struct bnx2x_prev_path_list), GFP_KERNEL);
+ tmp_list = kmalloc(sizeof(struct bnx2x_prev_path_list), GFP_KERNEL);
if (!tmp_list) {
BNX2X_ERR("Failed to allocate 'bnx2x_prev_path_list'\n");
return -ENOMEM;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bnx2x: remove cast around the kmalloc in bnx2x_prev_mark_path
2012-07-29 13:19 [PATCH] bnx2x: remove cast around the kmalloc in bnx2x_prev_mark_path Devendra Naga
@ 2012-07-30 4:50 ` Eilon Greenstein
2012-07-30 6:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eilon Greenstein @ 2012-07-30 4:50 UTC (permalink / raw)
To: netdev
On Sun, 2012-07-29 at 19:04 +0545, Devendra Naga wrote:
> casting the void pointer is redundant (Documentation/CodingStyle)
>
> Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Thanks Devendra, obviously, I’m acking this patch. I’m not so sure if it
should go into net though, and net-next is closed right now but this is
up to Dave.
Acked-by: Eilon Greenstein <eilong@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bnx2x: remove cast around the kmalloc in bnx2x_prev_mark_path
2012-07-29 13:19 [PATCH] bnx2x: remove cast around the kmalloc in bnx2x_prev_mark_path Devendra Naga
2012-07-30 4:50 ` Eilon Greenstein
@ 2012-07-30 6:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-07-30 6:19 UTC (permalink / raw)
To: develkernel412222; +Cc: eilong, netdev
From: Devendra Naga <develkernel412222@gmail.com>
Date: Sun, 29 Jul 2012 19:04:23 +0545
> casting the void pointer is redundant (Documentation/CodingStyle)
>
> Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-30 6:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-29 13:19 [PATCH] bnx2x: remove cast around the kmalloc in bnx2x_prev_mark_path Devendra Naga
2012-07-30 4:50 ` Eilon Greenstein
2012-07-30 6:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).