* [PATCH 0/1] mISDN: Fix regression with AVM Fritz!PCI cards @ 2012-07-29 17:15 Karsten Keil 2012-07-29 17:15 ` [PATCH 1/1] mISDN: Bugfix only few bytes are transfered on a connection Karsten Keil 0 siblings, 1 reply; 3+ messages in thread From: Karsten Keil @ 2012-07-29 17:15 UTC (permalink / raw) To: davem; +Cc: netdev, tobias.powalowski This patch does fix https://bugzilla.kernel.org/show_bug.cgi?id=45271. The bug was introduced in 3.5. and so the fix should go into 3.5 stable series and into 3.6. Best Regards Karsten Karsten Keil (1): mISDN: Bugfix only few bytes are transfered on a connection drivers/isdn/hardware/mISDN/avmfritz.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) -- 1.7.7 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] mISDN: Bugfix only few bytes are transfered on a connection 2012-07-29 17:15 [PATCH 0/1] mISDN: Fix regression with AVM Fritz!PCI cards Karsten Keil @ 2012-07-29 17:15 ` Karsten Keil 2012-07-30 6:19 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: Karsten Keil @ 2012-07-29 17:15 UTC (permalink / raw) To: davem; +Cc: netdev, tobias.powalowski The test for the fillempty condition was wrong in one place. Changed the variable to the right boolean type. Signed-off-by: Karsten Keil <keil@b1-systems.de> --- drivers/isdn/hardware/mISDN/avmfritz.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/isdn/hardware/mISDN/avmfritz.c b/drivers/isdn/hardware/mISDN/avmfritz.c index c08fc60..fa6ca47 100644 --- a/drivers/isdn/hardware/mISDN/avmfritz.c +++ b/drivers/isdn/hardware/mISDN/avmfritz.c @@ -449,7 +449,8 @@ hdlc_fill_fifo(struct bchannel *bch) { struct fritzcard *fc = bch->hw; struct hdlc_hw *hdlc; - int count, fs, cnt = 0, idx, fillempty = 0; + int count, fs, cnt = 0, idx; + bool fillempty = false; u8 *p; u32 *ptr, val, addr; @@ -462,7 +463,7 @@ hdlc_fill_fifo(struct bchannel *bch) return; count = fs; p = bch->fill; - fillempty = 1; + fillempty = true; } else { count = bch->tx_skb->len - bch->tx_idx; if (count <= 0) @@ -477,7 +478,7 @@ hdlc_fill_fifo(struct bchannel *bch) hdlc->ctrl.sr.cmd |= HDLC_CMD_XME; } ptr = (u32 *)p; - if (fillempty) { + if (!fillempty) { pr_debug("%s.B%d: %d/%d/%d", fc->name, bch->nr, count, bch->tx_idx, bch->tx_skb->len); bch->tx_idx += count; -- 1.7.7 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mISDN: Bugfix only few bytes are transfered on a connection 2012-07-29 17:15 ` [PATCH 1/1] mISDN: Bugfix only few bytes are transfered on a connection Karsten Keil @ 2012-07-30 6:19 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2012-07-30 6:19 UTC (permalink / raw) To: keil; +Cc: netdev, tobias.powalowski From: Karsten Keil <keil@b1-systems.de> Date: Sun, 29 Jul 2012 19:15:13 +0200 > The test for the fillempty condition was wrong in one place. > Changed the variable to the right boolean type. > > Signed-off-by: Karsten Keil <keil@b1-systems.de> Applied. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-30 6:19 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-29 17:15 [PATCH 0/1] mISDN: Fix regression with AVM Fritz!PCI cards Karsten Keil 2012-07-29 17:15 ` [PATCH 1/1] mISDN: Bugfix only few bytes are transfered on a connection Karsten Keil 2012-07-30 6:19 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).