netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kys@microsoft.com,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [PATCH net,1/1] hyperv: Add support for setting MAC from within guests
Date: Mon, 30 Jul 2012 14:39:27 +0200	[thread overview]
Message-ID: <20120730123927.GA29459@aepfle.de> (raw)
In-Reply-To: <1341940762-18307-1-git-send-email-haiyangz@microsoft.com>

On Tue, Jul 10, Haiyang Zhang wrote:

> diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
> index 981ebb1..fbf5394 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -47,6 +48,7 @@ struct rndis_request {
>  	struct hv_page_buffer buf;
>  	/* FIXME: We assumed a fixed size request here. */
>  	struct rndis_message request_msg;
> +	u8 ext[100];

This array is not referenced in the patch.
Please add a comment to the code what the purpose of this array is, and
why its size is 100 bytes.

Thanks.

Olaf

  parent reply	other threads:[~2012-07-30 12:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 17:19 [PATCH net, 1/1] hyperv: Add support for setting MAC from within guests Haiyang Zhang
2012-07-17  5:54 ` [PATCH net,1/1] " David Miller
2012-07-30 12:39 ` Olaf Hering [this message]
2012-07-30 19:48   ` Haiyang Zhang
  -- strict thread matches above, loose matches on Subject: below --
2012-07-06 21:25 Haiyang Zhang
2012-07-07  0:19 ` Ben Hutchings
2012-07-08  0:29   ` Haiyang Zhang
2012-07-10 17:03   ` Haiyang Zhang
2012-07-10 17:23     ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120730123927.GA29459@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=davem@davemloft.net \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).