From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ipv4: Properly purge netdev references on uncached routes.
Date: Tue, 31 Jul 2012 16:04:08 -0700 (PDT) [thread overview]
Message-ID: <20120731.160408.994710172149748635.davem@davemloft.net> (raw)
In-Reply-To: <20120731154455.2acf97a8@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 31 Jul 2012 15:44:55 -0700
> On Tue, 31 Jul 2012 15:20:33 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
>>
>> When a device is unregistered, we have to purge all of the
>> references to it that may exist in the entire system.
>>
>> If a route is uncached, we currently have no way of accomplishing
>> this.
>>
>> So create a global list that is scanned when a network device goes
>> down. This mirrors the logic in net/core/dst.c's dst_ifdown().
>>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> What about systems will full 1M route table?
> I wonder if doing rbtree here would make the search faster?
It only happens for routes like 255.255.255.255 and for those who
use tclassid on input.
Everything else is cached in the existing FIB trie entries.
next prev parent reply other threads:[~2012-07-31 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 22:20 [PATCH 2/2] ipv4: Properly purge netdev references on uncached routes David Miller
2012-07-31 22:44 ` Stephen Hemminger
2012-07-31 23:04 ` David Miller [this message]
2012-08-24 15:40 ` Eric Dumazet
2012-08-24 15:45 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-07-31 1:23 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120731.160408.994710172149748635.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).