From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Mason Subject: Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support Date: Wed, 1 Aug 2012 18:43:24 -0700 Message-ID: <20120802014324.GB17548@jonmason-lab> References: <1343607994-32415-1-git-send-email-jon.mason@intel.com> <1343607994-32415-2-git-send-email-jon.mason@intel.com> <20120730181542.GA987@jonmason-lab> <20120731172709.GB14080@jonmason-lab> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Bjorn Helgaas , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, Dave Jiang To: chetan loke Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pci-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Jul 31, 2012 at 02:02:25PM -0400, chetan loke wrote: > On Tue, Jul 31, 2012 at 1:27 PM, Jon Mason wrote: > > > > I don't see the benefit of having the driver in staging. Any vendors > > who would notice the ntb driver in staging would be sitting on these > > mailing lists and hopefully have planety of comments on the design. > > Stashing the driver in staging while waiting for these comments (which > > may never come) doesn't seem the best course of action. > > > > I thought that since others are talking about it then may be there is > some WIP code for foo-NTB. Seems like that's not the case. So no need > to stage. > > Correct me if I'm wrong but wouldn't apps just open a socket and route > data via ntb_vir_eth_dev? So I don't see an ABI breakage issue and > hence nothing would prevent us from changing the kernel parts(for > accommodating some foo-NTB part) in future. The virtual ethernet device (patch #2) would allow for a generic way of passing data to the remote side. The only issue would be changing how it is encoded in the shared buffer. > It may not be a bad idea to prefix intel-specific(if any) > ntb_structs/variables/logic with the 'intc'(Intel ticker or pick your > string) keyword. The Intel specific things are current pre-pended with "xeon" or "bwd". Thanks, Jon > > Chetan Loke