From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Daniel Mack <zonque@gmail.com>
Cc: netdev@vger.kernel.org, mugunthanvnm@ti.com, paul@pwsan.com,
devicetree-discuss@lists.ozlabs.org, koen@dominion.thruhere.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] net: davinci_mdio: enable and disable clock
Date: Thu, 2 Aug 2012 20:53:08 +0100 [thread overview]
Message-ID: <20120802195308.GZ6802@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1343936616-29318-1-git-send-email-zonque@gmail.com>
On Thu, Aug 02, 2012 at 09:43:35PM +0200, Daniel Mack wrote:
> Make the driver control the device clocks. Appearantly, the Davinci
> platform probes this driver with the clock all powered up, but on OMAP,
> this isn't the case.
Hmm, this looks like it could do with improvement, especially as we're
moving everything over to a common clk API.
1. This driver could do with clk_prepare()/clk_unprepare() calls.
2. This driver should not be making the assumption that NULL means
it can avoid clk_* calls. It should instead be using
if (!IS_ERR(clk))
Thanks.
next prev parent reply other threads:[~2012-08-02 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 19:43 [PATCH 1/2] net: davinci_mdio: enable and disable clock Daniel Mack
2012-08-02 19:43 ` [PATCH 2/2] net: davinci_mdio: add DT bindings Daniel Mack
2012-08-02 19:53 ` Russell King - ARM Linux [this message]
2012-08-02 20:17 ` [PATCH 1/2] net: davinci_mdio: enable and disable clock Daniel Mack
2012-08-02 20:20 ` Paul Walmsley
2012-08-02 20:28 ` Daniel Mack
2012-08-03 5:16 ` Vaibhav Hiremath
2012-08-03 5:22 ` Daniel Mack
2012-08-03 5:53 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120802195308.GZ6802@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=koen@dominion.thruhere.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).