From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: kgroeneveld@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] ppp: add 64 bit stats
Date: Fri, 03 Aug 2012 20:41:41 -0700 (PDT) [thread overview]
Message-ID: <20120803.204141.445487530122768077.davem@davemloft.net> (raw)
In-Reply-To: <1343461141.2626.13122.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 28 Jul 2012 09:39:01 +0200
> On Fri, 2012-07-27 at 23:38 -0400, Kevin Groeneveld wrote:
>> Add 64 bit stats to ppp driver. The 64 bit stats include tx_bytes,
>> rx_bytes, tx_packets and rx_packets. Other stats are still 32 bit.
>> The 64 bit stats can be retrieved via the ndo_get_stats operation. The
>> SIOCGPPPSTATS ioctl is still 32 bit stats only.
>>
>> Signed-off-by: Kevin Groeneveld <kgroeneveld@gmail.com>
>> ---
>> v2: - do not use percpu variables for stats
>> - use ppp_recv_lock/ppp_xmit_lock when reading 64 bit stats
>>
>
> Seems fine to me this time ;)
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2012-08-04 3:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 3:38 [PATCH v2] ppp: add 64 bit stats Kevin Groeneveld
2012-07-28 7:39 ` Eric Dumazet
2012-08-04 3:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803.204141.445487530122768077.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kgroeneveld@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).