From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv4: change inet_addr_hash()
Date: Sat, 04 Aug 2012 01:28:12 -0700 (PDT) [thread overview]
Message-ID: <20120804.012812.842569667363764548.davem@davemloft.net> (raw)
In-Reply-To: <1344064010.9299.1468.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 04 Aug 2012 09:06:50 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> Use net_hash_mix(net) instead of hash_ptr(net, 8), and use
> hash_32() instead of using a serie of XOR
>
> Define IN4_ADDR_HSIZE_SHIFT for clarity
>
> __ip_dev_find() can perform the net_eq() call only if ifa_local
> matches the key, to avoid unneeded dereferences.
>
> remove inline attributes
>
> # size net/ipv4/devinet.o.before net/ipv4/devinet.o
> text data bss dec hex filename
> 17471 2545 2048 22064 5630 net/ipv4/devinet.o.before
> 17335 2545 2048 21928 55a8 net/ipv4/devinet.o
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2012-08-04 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 7:06 [PATCH net-next] ipv4: change inet_addr_hash() Eric Dumazet
2012-08-04 8:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120804.012812.842569667363764548.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox