From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv4: Introduce IN_DEV_NET_ROUTE_LOCALNET
Date: Sat, 04 Aug 2012 01:28:17 -0700 (PDT) [thread overview]
Message-ID: <20120804.012817.197969934709246517.davem@davemloft.net> (raw)
In-Reply-To: <1344065245.9299.1477.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 04 Aug 2012 09:27:25 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> performance profiles show a high cost in the IN_DEV_ROUTE_LOCALNET()
> call done in ip_route_input_slow(), because of multiple dereferences,
> even if cache lines are clean and available in cpu caches.
>
> Since we already have the 'net' pointer, introduce
> IN_DEV_NET_ROUTE_LOCALNET() macro avoiding two dereferences
> (dev_net(in_dev->dev))
>
> Also change the tests to use IN_DEV_NET_ROUTE_LOCALNET() only if saddr
> or/and daddr are loopback addresse.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2012-08-04 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 7:27 [PATCH net-next] ipv4: Introduce IN_DEV_NET_ROUTE_LOCALNET Eric Dumazet
2012-08-04 8:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120804.012817.197969934709246517.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox