From: David Miller <davem@davemloft.net>
To: brutus@google.com
Cc: edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH v2] net-tcp: TCP/IP stack bypass for loopback connections
Date: Mon, 06 Aug 2012 17:24:02 -0700 (PDT) [thread overview]
Message-ID: <20120806.172402.650900841805469227.davem@davemloft.net> (raw)
In-Reply-To: <1344298429-19765-1-git-send-email-brutus@google.com>
From: "Bruce \"Brutus\" Curtis" <brutus@google.com>
Date: Mon, 6 Aug 2012 17:13:49 -0700
> + /*
> + * If friends haven't been made yet, our sk_friend
> + * still == NULL, then update with the ACK's friend
> + * value (the listen()er's sock addr) which is used
> + * as a place holder.
> + */
> + atomic_long_cmpxchg(&sk->sk_friend, 0,
> + (u64)skb->friend);
You probably want plain:
cmpxchg(&sk->sk_friend, NULL, skb->friend);
here.
Rather than using an expression that implies an equivalence between
the types 'long' and 'void *'
prev parent reply other threads:[~2012-08-07 0:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 0:13 [RFC][PATCH v2] net-tcp: TCP/IP stack bypass for loopback connections Bruce "Brutus" Curtis
2012-08-07 0:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120806.172402.650900841805469227.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brutus@google.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).