From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Yann Dupont <Yann.Dupont@univ-nantes.fr>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: skb_warn_bad_offload with kernel 3.5 (maybe gso/bridge related ?)
Date: Mon, 6 Aug 2012 21:42:32 +0800 [thread overview]
Message-ID: <20120806134232.GA19849@gondor.apana.org.au> (raw)
In-Reply-To: <1344250640.26674.9.camel@edumazet-glaptop>
On Mon, Aug 06, 2012 at 12:57:20PM +0200, Eric Dumazet wrote:
> On Mon, 2012-08-06 at 17:18 +0800, Herbert Xu wrote:
> > On Fri, Aug 03, 2012 at 04:40:08PM +0100, Ben Hutchings wrote:
> > >
> > > I think GRO is doing the right thing, and I can't think why we should
> > > see ip_summed = CHECKSUM_PARTIAL if the skb is forwarded by a bridge. I
> >
> > If it is was created by GRO then it should always be CHECKSUM_PARTIAL,
> > even if it came through a bridge.
>
> Not sure where in GRO we set ip_summed to CHECKSUM_PARTIAL ?
tcp_gro_complete
Chers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2012-08-06 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 8:10 skb_warn_bad_offload with kernel 3.5 (maybe gso/bridge related ?) Yann Dupont
2012-08-03 8:51 ` Eric Dumazet
2012-08-03 15:40 ` Ben Hutchings
2012-08-06 9:18 ` Herbert Xu
2012-08-06 10:50 ` Dmitry Kravkov
2012-08-06 10:57 ` Eric Dumazet
2012-08-06 13:42 ` Herbert Xu [this message]
2012-08-06 13:54 ` Eric Dumazet
2012-12-18 14:13 ` Yann Dupont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120806134232.GA19849@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Yann.Dupont@univ-nantes.fr \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox