From: David Miller <davem@davemloft.net>
To: Priyanka.Jain@freescale.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][XFRM] Replace rwlock on xfrm_policy_afinfo with rcu
Date: Tue, 07 Aug 2012 16:21:38 -0700 (PDT) [thread overview]
Message-ID: <20120807.162138.5000306557864030.davem@davemloft.net> (raw)
In-Reply-To: <1344316904-2544-1-git-send-email-Priyanka.Jain@freescale.com>
From: Priyanka Jain <Priyanka.Jain@freescale.com>
Date: Tue, 7 Aug 2012 10:51:44 +0530
> xfrm_policy_afinfo is read mosly data structure.
> Write on xfrm_policy_afinfo is done only at the
> time of configuration.
> So rwlocks can be safely replaced with RCU.
>
> RCUs usage optimizes the performance.
>
> Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
This patch doesn't apply to the net-next tree, please respin.
Also:
> - xfrm_policy_afinfo[afinfo->family] = NULL;
> + rcu_assign_pointer(xfrm_policy_afinfo[afinfo->family],
> + NULL);
Indent that NULL argument properly, it must line up with the first
column after the openning '(' on the previous line.
next prev parent reply other threads:[~2012-08-07 23:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 5:21 [PATCH][XFRM] Replace rwlock on xfrm_policy_afinfo with rcu Priyanka Jain
2012-08-07 23:21 ` David Miller [this message]
2012-08-08 4:53 ` Jain Priyanka-B32167
2012-08-08 5:55 ` David Miller
2012-08-08 9:41 ` Jain Priyanka-B32167
2012-08-08 6:25 ` Eric Dumazet
2012-08-08 6:44 ` Fan Du
2012-08-10 4:28 ` Jain Priyanka-B32167
2012-08-10 6:26 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807.162138.5000306557864030.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Priyanka.Jain@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).