From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: [RFC v3 1/7] hashtable: introduce a small and naive hashtable Date: Mon, 6 Aug 2012 19:55:20 -0700 Message-ID: <20120807025520.GA3823@leaf> References: <1344300317-23189-1-git-send-email-levinsasha928@gmail.com> <1344300317-23189-2-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: torvalds@linux-foundation.org, tj@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, paul.gortmaker@windriver.com, davem@davemloft.net, rostedt@goodmis.org, mingo@elte.hu, ebiederm@xmission.com, aarcange@redhat.com, ericvh@gmail.com, netdev@vger.kernel.org, eric.dumazet@gmail.com, mathieu.desnoyers@efficios.com To: Sasha Levin Return-path: Content-Disposition: inline In-Reply-To: <1344300317-23189-2-git-send-email-levinsasha928@gmail.com> Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org On Tue, Aug 07, 2012 at 02:45:10AM +0200, Sasha Levin wrote: > +/** > + * hash_add - add an object to a hashtable > + * @hashtable: hashtable to add to > + * @bits: bit count used for hashing > + * @node: the &struct hlist_node of the object to be added > + * @key: the key of the object to be added > + */ > +#define hash_add(hashtable, bits, node, key) \ > + hlist_add_head(node, &hashtable[hash_min(key, bits)]); Any particular reason to make this a macro rather than a static inline? Also, even if you do make it a macro, don't include the semicolon. > +/** > + * hash_for_each_possible - iterate over all possible objects for a giver key s/giver/given/ > + * @name: hashtable to iterate > + * @obj: the type * to use as a loop cursor for each bucke s/bucke/bucket/ - Josh Triplett -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org