From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: fib: fix incorrect call_rcu_bh()
Date: Tue, 7 Aug 2012 10:07:02 -0700 [thread overview]
Message-ID: <20120807170702.GH2378@linux.vnet.ibm.com> (raw)
In-Reply-To: <1344358094.28967.116.camel@edumazet-glaptop>
On Tue, Aug 07, 2012 at 06:48:14PM +0200, Eric Dumazet wrote:
> On Tue, 2012-08-07 at 09:34 -0700, Paul E. McKenney wrote:
> > On Tue, Aug 07, 2012 at 12:47:11PM +0200, Eric Dumazet wrote:
> > > From: Eric Dumazet <edumazet@google.com>
> > >
> > > After IP route cache removal, I believe rcu_bh() has very little use and
> > > we should remove this RCU variant, since it adds some cycles in fast
> > > path.
> >
> > Do you mean remove all uses of RCU-bh globally and also removing the
> > implementation itself? That would actually be a good thing, from my
> > perspective.
> >
>
> Yes I meant that there are now too few rcu_bh users, and that they
> probably could switch to regular rcu.
>
> We could then remove the implementation.
>
> rcu_bh was needed because we could sit forever in softirq mode in one
> cpu, and we needed to allocate/free dsts with RCU protection.
Very cool!!! Anything I can do to help, aside of course from the final
removal of RCU-bh support?
Thanx, Paul
next prev parent reply other threads:[~2012-08-07 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 10:47 [PATCH] net: fib: fix incorrect call_rcu_bh() Eric Dumazet
2012-08-07 16:34 ` Paul E. McKenney
2012-08-07 16:48 ` Eric Dumazet
2012-08-07 17:07 ` Paul E. McKenney [this message]
2012-08-08 22:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807170702.GH2378@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).