From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v3 0/14] some netpoll and netconsole fixes
Date: Thu, 09 Aug 2012 21:03:19 -0700 (PDT) [thread overview]
Message-ID: <20120809.210319.607775008694193852.davem@davemloft.net> (raw)
In-Reply-To: <1344564802.17296.1.camel@cr0>
From: Cong Wang <amwang@redhat.com>
Date: Fri, 10 Aug 2012 10:13:22 +0800
> On Thu, 2012-08-09 at 16:36 -0700, David Miller wrote:
>> From: David Miller <davem@davemloft.net>
>> Date: Thu, 09 Aug 2012 16:30:46 -0700 (PDT)
>>
>> > From: Cong Wang <amwang@redhat.com>
>> > Date: Thu, 9 Aug 2012 23:00:12 +0800
>> >
>> >> V3:
>> >> * add more patches
>> >> * update patch 7 as David suggested
>> >>
>> >> V2:
>> >> * update patch 1/8 as Eric suggested
>> >> * drop the bridge patch, add comments instead
>> >> * add patch 8/8
>> >>
>> >> This patchset fixes serval problems in netconsole and netpoll.
>> >>
>> >> I ran this patch in my KVM guest with some netpoll test cases,
>> >> even covered with some corner cases, everything worked as expected.
>> >
>> > All applied to 'net', thanks for fixing all of this stuff.
>>
>> Actually, you didn't test the build very well, I'm reverting:
>>
>> In file included from drivers/net/team/team_mode_broadcast.c:17:0:
>> include/linux/if_team.h: In function ‘team_dev_queue_xmit’:
>> include/linux/if_team.h:107:6: error: dereferencing pointer to incomplete type
>> make[3]: *** [drivers/net/team/team_mode_broadcast.o] Error 1
>> make[3]: *** Waiting for unfinished jobs....
>> In file included from drivers/net/team/team.c:31:0:
>> include/linux/if_team.h: In function ‘team_dev_queue_xmit’:
>> include/linux/if_team.h:107:6: error: dereferencing pointer to incomplete type
>> make[3]: *** [drivers/net/team/team.o] Error 1
>> make[2]: *** [drivers/net/team] Error 2
>> make[2]: *** Waiting for unfinished jobs....
>
> Oops! Sorry that I forgot to enable CONFIG_NET_TEAM.
>
> Do you want me to send a delta patch or send v4?
Please resend the full series.
prev parent reply other threads:[~2012-08-10 4:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 15:00 [PATCH v3 0/14] some netpoll and netconsole fixes Cong Wang
2012-08-09 15:00 ` [PATCH 01/14] netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup() Cong Wang
2012-08-09 15:00 ` [PATCH 02/14] netpoll: make __netpoll_cleanup non-block Cong Wang
2012-08-09 15:00 ` [PATCH 03/14] netconsole: do not release spin_lock when calling __netpoll_cleanup Cong Wang
2012-08-09 15:00 ` [PATCH 04/14] netpoll: take rcu_read_lock_bh() in netpoll_rx() Cong Wang
2012-08-09 15:00 ` [PATCH 05/14] netpoll: use netpoll_rx_on() " Cong Wang
2012-08-09 15:00 ` [PATCH 06/14] netpoll: take rcu_read_lock_bh() in netpoll_send_skb_on_dev() Cong Wang
2012-08-09 15:00 ` [PATCH 07/14] bridge: add some comments for NETDEV_RELEASE Cong Wang
2012-08-09 15:00 ` [PATCH 08/14] bridge: use list_for_each_entry() in netpoll functions Cong Wang
2012-08-09 15:00 ` [PATCH 09/14] netpoll: check netpoll tx status on the right device Cong Wang
2012-08-09 15:00 ` [PATCH 10/14] netpoll: convert several functions to bool Cong Wang
2012-08-09 15:00 ` [PATCH 11/14] vlan: clean up vlan_dev_hard_start_xmit() Cong Wang
2012-08-09 15:00 ` [PATCH 12/14] netpoll: handle vlan tags in netpoll tx and rx path Cong Wang
2012-08-09 15:00 ` [PATCH 13/14] netpoll: re-enable irq in poll_napi() Cong Wang
2012-08-09 15:00 ` [PATCH 14/14] netconsole.txt: revision of examples for the receiver of kernel messages Cong Wang
2012-08-09 23:30 ` [PATCH v3 0/14] some netpoll and netconsole fixes David Miller
2012-08-09 23:36 ` David Miller
2012-08-10 2:13 ` Cong Wang
2012-08-10 4:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809.210319.607775008694193852.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).