From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ipv4: tcp: unicast_sock should not land outside of TCP stack Date: Thu, 09 Aug 2012 21:05:46 -0700 (PDT) Message-ID: <20120809.210546.819623704116134361.davem@davemloft.net> References: <1344547743.31104.582.camel@edumazet-glaptop> <20120809.163851.1182547052663187702.davem@davemloft.net> <1344556566.31104.808.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: eparis@parisplace.org, paul@paul-moore.com, casey@schaufler-ca.com, johnstul@us.ibm.com, serge@hallyn.com, linux-kernel@vger.kernel.org, james.l.morris@oracle.com, selinux@tycho.nsa.gov, john.johansen@canonical.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org To: eric.dumazet@gmail.com Return-path: In-Reply-To: <1344556566.31104.808.camel@edumazet-glaptop> Sender: linux-security-module-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Eric Dumazet Date: Fri, 10 Aug 2012 01:56:06 +0200 > From: Eric Dumazet > > commit be9f4a44e7d41cee (ipv4: tcp: remove per net tcp_sock) added a > selinux regression, reported and bisected by John Stultz > > selinux_ip_postroute_compat() expect to find a valid sk->sk_security > pointer, but this field is NULL for unicast_sock > > It turns out that unicast_sock are really temporary stuff to be able > to reuse part of IP stack (ip_append_data()/ip_push_pending_frames()) > > Fact is that frames sent by ip_send_unicast_reply() should be orphaned > to not fool LSM. > > Note IPv6 never had this problem, as tcp_v6_send_response() doesnt use a > fake socket at all. I'll probably implement tcp_v4_send_response() to > remove these unicast_sock in linux-3.7 > > Reported-by: John Stultz > Bisected-by: John Stultz > Signed-off-by: Eric Dumazet Applied.