From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH] net: add new QCA alx ethernet driver Date: Thu, 9 Aug 2012 10:54:54 -0400 Message-ID: <20120809145454.GA21195@home.goodmis.org> References: <6349D7A510622448B1BA0967850A8438013692CA@NASANEXD02D.na.qualcomm.com> <1344485382.2024.9.camel@joe2Laptop> <6349D7A510622448B1BA0967850A843801369364@NASANEXD02D.na.qualcomm.com> <20120808.231804.12694947300243733.davem@davemloft.net> <6349D7A510622448B1BA0967850A8438013693DD@NASANEXD02D.na.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , "joe@perches.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , qca-linux-team , nic-devel , "Huang, Xiong" , "hao-ran.liu@canonical.com" , "Rodriguez, Luis" To: "Ren, Cloud" Return-path: Content-Disposition: inline In-Reply-To: <6349D7A510622448B1BA0967850A8438013693DD@NASANEXD02D.na.qualcomm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Aug 09, 2012 at 06:49:25AM +0000, Ren, Cloud wrote: > > Please calm down. I will follow rule of sending email from now on. Sorry for causing > your trouble. Luis has ever asked joe for adding as a Signed-off-by. At that time joe agreed > with it. If joe prefers his name not be listed as a Signed-off-by, I will respect his decision. > alx driver is innocent. Please help review. Thanks I'm curious, did Luis ask on list or off? When I ask someone for a Signed-off-by tag, I always ask them to post it to the list, even when they have given it to me privately. I like others to see that someone explicitly gave me their permission, as I would never add a Signed-off tag for someone else. The Signed-off tag has some legal bindings (all other tags are for credit/info only). It is that person saying that the changes they made to a patch are theirs and are giving the right to distribute it. It is also used by those that take the changes and insert it into the repository. >>From Documentation/SubmittingPatches: The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as an open-source patch. Joe, If you actually modified part of the code in the patch, you do have the right to add a signed-off-by tag. If you just made suggestions or reviewed, then a 'Suggested-by' or 'Reviewed-by' tag would be more appropriate. The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. -- Steve