From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jpirko@redhat.com>
Subject: Re: [net-next] bonding: don't allow the master to become its slave
Date: Thu, 9 Aug 2012 21:55:39 +0200
Message-ID: <20120809195539.GB1783@minipsycho.orion>
References: <1344537049-11473-1-git-send-email-fbl@redhat.com>
 <1344539003.2593.7.camel@bwh-desktop.uk.solarflarecom.com>
 <20120809163906.6dc0b6d4@obelix.rh>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ben Hutchings <bhutchings@solarflare.com>,
	netdev <netdev@vger.kernel.org>, Jay Vosburgh <fubar@us.ibm.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	Leonardo Chiquitto <lchiquitto@suse.com>
To: Flavio Leitner <fbl@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:38143 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755071Ab2HITzs (ORCPT <rfc822;netdev@vger.kernel.org>);
	Thu, 9 Aug 2012 15:55:48 -0400
Content-Disposition: inline
In-Reply-To: <20120809163906.6dc0b6d4@obelix.rh>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Thu, Aug 09, 2012 at 09:39:06PM CEST, fbl@redhat.com wrote:
>On Thu, 9 Aug 2012 20:03:23 +0100
>Ben Hutchings <bhutchings@solarflare.com> wrote:
>
>> On Thu, 2012-08-09 at 15:30 -0300, Flavio Leitner wrote:
>> > It doesn't make any sense to allow the master to become
>> > its slave. That creates a loop of events causing a crash.
>> 
>> What if there are other intermediate devices, e.g. the slave is a VLAN
>> sub-device of the bond?  And doesn't team also have this problem?
>> 
>> I think a more general check for such loops might be required.
>
>Maybe patching netdev_set_master() to fail in the loop case is
>the way to go.  That would work for bonding, team and bridge.
>
>What you think?


How about other devices who do not use "->master" like vlan, macvlan?
>
>fbl