netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: David Miller <davem@davemloft.net>
Cc: fubar@us.ibm.com, bhutchings@solarflare.com, jpirko@redhat.com,
	fbl@redhat.com, netdev@vger.kernel.org, andy@greyhouse.net,
	lchiquitto@suse.com
Subject: Re: [net-next] bonding: don't allow the master to become its slave
Date: Fri, 10 Aug 2012 15:04:01 +0200	[thread overview]
Message-ID: <20120810130401.GC1543@minipsycho> (raw)
In-Reply-To: <20120809.164331.1709422829981798177.davem@davemloft.net>

Fri, Aug 10, 2012 at 01:43:31AM CEST, davem@davemloft.net wrote:
>From: Jay Vosburgh <fubar@us.ibm.com>
>Date: Thu, 09 Aug 2012 14:27:08 -0700
>
>> 	If that's hard to do (and it might be; I'm not aware of a
>> standard way to run up and down those stacks of interfaces, which might
>> not always be vlans in the middle), there's still the priv_flags &
>> IFF_BONDING test that bonding could (and probably should) do itself as
>> well.  The team driver could presumably have a similar test, although I
>> seem to recall that team was allowed to nest.
>> 
>> 	FWIW, I've seen both the top and bottom halves of that picture
>> in use (i.e., bonds consisting of vlans as slaves or bonds with vlans
>> configured above them), but not combined as in your diagram.
>
>We're basically looking for cycles in a complex graph.
>
>Some combination of Jay and Ben's most recent patches, with some minor
>modifications, ought to do it.


Hmm. Would be probably good to have list/table of related devices,
possibly with information about the relation.
After that, every relation add would check for loops.

I will dive in the code over the weekend to see if this is doable in
some nice way.

>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-08-10 13:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 18:30 [net-next] bonding: don't allow the master to become its slave Flavio Leitner
2012-08-09 18:45 ` Leonardo Chiquitto
2012-08-09 19:03 ` Ben Hutchings
2012-08-09 19:23   ` Jay Vosburgh
2012-08-09 19:39   ` Flavio Leitner
2012-08-09 19:55     ` Jiri Pirko
2012-08-09 20:52       ` Flavio Leitner
2012-08-09 21:09       ` Ben Hutchings
2012-08-09 21:27         ` Jay Vosburgh
2012-08-09 23:43           ` David Miller
2012-08-10 13:04             ` Jiri Pirko [this message]
2012-08-09 19:54   ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120810130401.GC1543@minipsycho \
    --to=jiri@resnulli.us \
    --cc=andy@greyhouse.net \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=fbl@redhat.com \
    --cc=fubar@us.ibm.com \
    --cc=jpirko@redhat.com \
    --cc=lchiquitto@suse.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).