From: David Miller <davem@davemloft.net>
To: yefremov.denis@gmail.com
Cc: mst@redhat.com, jasowang@redhat.com, ebiederm@xmission.com,
ian.campbell@citrix.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@ispras.ru
Subject: Re: [PATCH] macvtap: rcu_dereference outside read-lock section
Date: Sat, 11 Aug 2012 18:16:42 -0700 (PDT) [thread overview]
Message-ID: <20120811.181642.1587792778007257202.davem@davemloft.net> (raw)
In-Reply-To: <1344679527-13377-1-git-send-email-yefremov.denis@gmail.com>
From: Denis Efremov <yefremov.denis@gmail.com>
Date: Sat, 11 Aug 2012 14:05:27 +0400
> - if (rcu_dereference(vlan->taps[i]) == q)
> + if (rcu_dereference_protected(vlan->taps[i],
> + lockdep_is_held(&macvtap_lock)) == q)
You must use the proper combination of TAB character and spaces
to line up the lockdep_is_held() argument with the first column
after openning "(" on the previous line.
Never be lazy and use only TABs.
next prev parent reply other threads:[~2012-08-12 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 10:05 [PATCH] macvtap: rcu_dereference outside read-lock section Denis Efremov
2012-08-12 1:16 ` David Miller [this message]
2012-08-12 6:26 ` [PATCH v2] " Denis Efremov
2012-08-12 8:49 ` Michael S. Tsirkin
2012-08-12 20:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120811.181642.1587792778007257202.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=ian.campbell@citrix.com \
--cc=jasowang@redhat.com \
--cc=ldv-project@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=yefremov.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).