From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] net: add new QCA alx ethernet driver Date: Sat, 11 Aug 2012 13:50:44 -0700 Message-ID: <20120811135044.529a7081@nehalam.linuxnetplumber.net> References: <1344507270-2907-1-git-send-email-cjren@qca.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: , , , , , Xiong Huang , "Hao-Ran Liu(Joseph Liu)" , Joe Perches , "Luis R. Rodriguez" To: Return-path: In-Reply-To: <1344507270-2907-1-git-send-email-cjren@qca.qualcomm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 9 Aug 2012 18:14:30 +0800 wrote: > + strcpy(netdev->name, "eth%d"); > + retval = register_netdev(netdev); The strcpy is unnecessary, alloc_etherdev already sets that.