From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] configure: Add search path for 64bit library. Date: Mon, 13 Aug 2012 08:26:24 -0700 Message-ID: <20120813082624.153167a8@nehalam.linuxnetplumber.net> References: <1344313376-22602-1-git-send-email-lw@cn.fujitsu.com> <1344363358.2688.8.camel@bwh-desktop.uk.solarflarecom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Li Wei , To: Ben Hutchings Return-path: Received: from mail.vyatta.com ([76.74.103.46]:35421 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938Ab2HMP0f (ORCPT ); Mon, 13 Aug 2012 11:26:35 -0400 In-Reply-To: <1344363358.2688.8.camel@bwh-desktop.uk.solarflarecom.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 7 Aug 2012 19:15:58 +0100 Ben Hutchings wrote: > The subject line doesn't say what this is for, but it looks like > iproute2... > > On Tue, 2012-08-07 at 12:22 +0800, Li Wei wrote: > > Signed-off-by: Li Wei > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 0f4444f..997759c 100755 > > --- a/configure > > +++ b/configure > > @@ -149,7 +149,7 @@ check_ipt() > > check_ipt_lib_dir() > > { > > IPT_LIB_DIR="" > > - for dir in /lib /usr/lib /usr/local/lib > > + for dir in /lib /usr/lib /usr/local/lib /lib64 /usr/lib64 /usr/local/lib64 > > do > > for file in $dir/{xtables,iptables}/lib*t_*so ; do > > if [ -f $file ]; then > > On a bi-arch system, surely the lib64 directories should be preferred to > the lib directories? And this still leaves multi-arch to be handled. > > I think this should be done with pkg-config: > > pkg-config --variable=xtlibdir xtables > > possibly with that directory list as a fallback if it's useful to > support iptables library versions that didn't include xtables.pc. > > Ben. > Does every distro have pkg-config or does more logic need to be done here?