From: David Miller <davem@davemloft.net>
To: brutus@google.com
Cc: edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net-tcp: TCP/IP stack bypass for loopback connections
Date: Tue, 14 Aug 2012 14:22:28 -0700 (PDT) [thread overview]
Message-ID: <20120814.142228.85041202742435369.davem@davemloft.net> (raw)
In-Reply-To: <1344559958-29162-1-git-send-email-brutus@google.com>
Bruce, could you integrate (and unlike your submission, actually build
and run test) Weiping's bug fixes?
Actually, I'm actually a little bit alarmed at Weiping's fixes,
because it makes it look as if you didn't test things at all under
net-next, as it appears that without his fixes any loopback TCP
connection would OOPS the kernel.
In fact, it wouldn't even build without the sysctl_tcp_friends typo.
Indeed:
net/ipv4/tcp.c: In function ‘tcp_recvmsg’:
net/ipv4/tcp.c:1935:35: error: ‘friends’ undeclared (first use in this function)
net/ipv4/tcp.c:1935:35: note: each undeclared identifier is reported only once for each function it appears in
I hope I don't need to tell you how unacceptable this is.
That also means that all of your measurements in the commit message
weren't even made in the context where this patch will be applied.
Also unacceptable.
All of this makes for an extremely poor quality submission, please
correct these issues.
next prev parent reply other threads:[~2012-08-14 21:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 0:52 [PATCH v2] net-tcp: TCP/IP stack bypass for loopback connections Bruce "Brutus" Curtis
2012-08-14 3:12 ` [PATCH] TCP/IP stack bypass for loopback connections fix Weiping Pan
2012-08-14 6:31 ` [PATCH v2] net-tcp: TCP/IP stack bypass for loopback connections Bill Fink
2012-08-14 7:37 ` David Miller
2012-08-23 16:41 ` Stephen Clark
2012-08-14 16:19 ` Bruce Curtis
2012-08-15 5:24 ` Bill Fink
2012-08-15 5:39 ` David Miller
2012-08-15 16:17 ` Bill Fink
2012-08-14 21:22 ` David Miller [this message]
2012-08-14 21:45 ` Bruce Curtis
2012-08-14 21:50 ` David Miller
2012-08-23 10:57 ` Pádraig Brady
2012-08-23 11:40 ` Eric Dumazet
2012-09-09 17:54 ` Jan Engelhardt
2012-09-09 21:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814.142228.85041202742435369.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brutus@google.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).