From: David Miller <davem@davemloft.net>
To: zheng.z.yan@intel.com
Cc: netdev@vger.kernel.org, alex.shi@intel.com
Subject: Re: [PATCH] ipv4: Cache local output routes
Date: Tue, 14 Aug 2012 14:47:29 -0700 (PDT) [thread overview]
Message-ID: <20120814.144729.2212634746787730897.davem@davemloft.net> (raw)
In-Reply-To: <50289A37.6000209@intel.com>
From: "Yan, Zheng" <zheng.z.yan@intel.com>
Date: Mon, 13 Aug 2012 14:09:59 +0800
> Commit caacf05e5ad1abf causes big drop of UDP loop back performance.
> The cause of the regression is that we do not cache the local output
> routes. Each time we send a datagram from unconnected UDP socket,
> the kernel allocates a dst_entry and adds it to the rt_uncached_list.
> It creates lock contention on the rt_uncached_lock.
>
> Reported-by: Alex Shi <alex.shi@intel.com>
> Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
I was pretty sure not using 'fi' was necessary for semantic
reasons here, but I can't find any such requirement, so I've
applied this, thanks.
prev parent reply other threads:[~2012-08-14 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 6:09 [PATCH] ipv4: Cache local output routes Yan, Zheng
2012-08-14 21:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814.144729.2212634746787730897.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.shi@intel.com \
--cc=netdev@vger.kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).