From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: acme@ghostprotocols.net, netdev@vger.kernel.org
Subject: Re: [PATCH net 1/3] llc2: Fix silent failure of llc_station_init()
Date: Tue, 14 Aug 2012 16:52:11 -0700 (PDT) [thread overview]
Message-ID: <20120814.165211.2173895464645202364.davem@davemloft.net> (raw)
In-Reply-To: <1344862199.824.140.camel@deadeye.wl.decadent.org.uk>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Mon, 13 Aug 2012 13:49:59 +0100
> llc_station_init() creates and processes an event skb with no effect
> other than to change the state from DOWN to UP. Allocation failure is
> reported, but then ignored by its caller, llc2_init(). Remove this
> possibility by simply initialising the state as UP.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Applied.
next prev parent reply other threads:[~2012-08-14 23:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 12:48 [PATCH net 0/3] llc2 station handler fixes Ben Hutchings
2012-08-13 12:49 ` [PATCH net 1/3] llc2: Fix silent failure of llc_station_init() Ben Hutchings
2012-08-14 23:52 ` David Miller [this message]
2012-08-13 12:50 ` [PATCH net 2/3] llc2: Call llc_station_exit() on llc2_init() failure path Ben Hutchings
2012-08-14 23:52 ` David Miller
2012-08-15 4:06 ` Ben Hutchings
2012-08-13 12:50 ` [PATCH net 3/3] llc: Fix races between llc2 handler use and (un)registration Ben Hutchings
2012-08-14 23:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814.165211.2173895464645202364.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@ghostprotocols.net \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).