From: David Miller <davem@davemloft.net>
To: rghitulete@ixiacom.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org, dbaluta@ixiacom.com
Subject: Re: [PATCH] net: remove wrong initialization for snd_wl1
Date: Wed, 15 Aug 2012 15:23:34 -0700 (PDT) [thread overview]
Message-ID: <20120815.152334.334391000010431604.davem@davemloft.net> (raw)
In-Reply-To: <1344951021-22667-1-git-send-email-rghitulete@ixiacom.com>
From: Razvan Ghitulete <rghitulete@ixiacom.com>
Date: Tue, 14 Aug 2012 16:30:20 +0300
> The field tp->snd_wl1 is twice initialized, the second time
> seems to be wrong as it may overwrite any update in tcp_ack.
>
> Signed-off-by: Razvan Ghitulete <rghitulete@ixiacom.com>
I'll apply this, but it is mere redundancy.
The only thing tcp_ack() can set tp->snd_wl1 to is TCP_SKB_CB(skb)->seq
which is exactly what it is being set to here as well.
prev parent reply other threads:[~2012-08-15 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 13:30 [PATCH] net: remove wrong initialization for snd_wl1 Razvan Ghitulete
2012-08-15 22:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815.152334.334391000010431604.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dbaluta@ixiacom.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=rghitulete@ixiacom.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).