From: David Miller <davem@davemloft.net>
To: john.r.fastabend@intel.com
Cc: viro@ZenIV.linux.org.uk, nhorman@tuxdriver.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
joe@perches.com
Subject: Re: [net PATCH v3 2/3] net: netprio: fd passed in SCM_RIGHTS datagram not set correctly
Date: Thu, 16 Aug 2012 15:11:51 -0700 (PDT) [thread overview]
Message-ID: <20120816.151151.1086500546875406230.davem@davemloft.net> (raw)
In-Reply-To: <20120814223430.3551.88909.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Tue, 14 Aug 2012 15:34:30 -0700
> A socket fd passed in a SCM_RIGHTS datagram was not getting
> updated with the new tasks cgrp prioidx. This leaves IO on
> the socket tagged with the old tasks priority.
>
> To fix this add a check in the scm recvmsg path to update the
> sock cgrp prioidx with the new tasks value.
>
> Thanks to Al Viro for catching this.
>
> CC: Neil Horman <nhorman@tuxdriver.com>
> Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
next prev parent reply other threads:[~2012-08-16 22:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 22:34 [net PATCH v3 1/3] net: netprio: fix files lock and remove useless d_path bits John Fastabend
2012-08-14 22:34 ` [net PATCH v3 2/3] net: netprio: fd passed in SCM_RIGHTS datagram not set correctly John Fastabend
2012-08-15 10:53 ` Neil Horman
2012-08-16 22:11 ` David Miller [this message]
2012-08-14 22:34 ` [net PATCH v3 3/3] net: netprio: fix cgrp create and write priomap race John Fastabend
2012-08-15 10:56 ` Neil Horman
2012-08-16 22:11 ` David Miller
2012-08-15 10:52 ` [net PATCH v3 1/3] net: netprio: fix files lock and remove useless d_path bits Neil Horman
2012-08-15 20:03 ` Al Viro
2012-08-16 22:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816.151151.1086500546875406230.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).