From: David Miller <davem@davemloft.net>
To: paul.gortmaker@windriver.com
Cc: fan.du@windriver.com, fengguang.wu@intel.com,
Priyanka.Jain@freescale.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: suspicious RCU usage in xfrm_net_init()
Date: Thu, 16 Aug 2012 19:41:29 -0700 (PDT) [thread overview]
Message-ID: <20120816.194129.1416562963060076374.davem@davemloft.net> (raw)
In-Reply-To: <CAP=VYLqHW+NOS-gPgUkUpZh-Vim2jkmMT7NK+7uRbg730d=xHw@mail.gmail.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Thu, 16 Aug 2012 21:34:25 -0400
> Also, a patch should describe the problem it solves (i.e. the symptom
> the end user sees), and how the problem originated, and why the fix
> in the patch is the _right_ fix. The worst description a commit log
> can have is one that just describes the C change in words, since
> most people can read C on their own.
I've frankly given up on Fan Du submitting sophisticated patches
that are easy to review and are properly documented.
Just getting simple things like a WORKING EMAIL ADDRESS was beyond a
struggle.
So when I get a patch that applies, from a properly working email
address, it's an accomplishment.
next prev parent reply other threads:[~2012-08-17 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 7:37 suspicious RCU usage in xfrm_net_init() Fengguang Wu
2012-08-16 9:36 ` Fan Du
2012-08-16 15:19 ` Fengguang Wu
2012-08-17 1:07 ` Fan Du
2012-08-17 1:34 ` Paul Gortmaker
2012-08-17 2:03 ` Fan Du
2012-08-17 2:41 ` David Miller [this message]
2012-08-17 2:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816.194129.1416562963060076374.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Priyanka.Jain@freescale.com \
--cc=fan.du@windriver.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).