From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v0 5/5] cgroup: Assign subsystem IDs during compile time Date: Thu, 16 Aug 2012 16:20:10 -0700 Message-ID: <20120816232010.GJ24861@google.com> References: <1345126336-20755-1-git-send-email-wagi@monom.org> <1345126336-20755-6-git-send-email-wagi@monom.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Wagner , "David S. Miller" , Andrew Morton , Eric Dumazet , Gao feng , Glauber Costa , Jamal Hadi Salim , John Fastabend , Kamezawa Hiroyuki , Li Zefan , Neil Horman To: Daniel Wagner Return-path: Content-Disposition: inline In-Reply-To: <1345126336-20755-6-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, Aug 16, 2012 at 04:12:16PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > We are able to safe some space when we assign the subsystem > IDs at compile time. Instead of allocating per cgroup > cgroup->subsys[CGROUP_SUBSYS_COUNT] where CGROUP_SUBSYS_COUNT is > always 64, we allocate 12 + 1 at max (at this point there are 12 > subsystem). So, IIUC, this is effectively removing the capability to implement modularized controller which isn't known at kernel compile time. Am I right? I don't think that's a bad idea but if we're doing that, can't we make things even simpler? Do we need to distinguish in-kernel and module at all? Li, what do you think about this? Thanks. -- tejun