From: Greg KH <gregkh@linuxfoundation.org>
To: Huang Shijie <shijie8@gmail.com>
Cc: alan@linux.intel.com, jirislaby@gmail.com,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] serial: add a new helper function
Date: Sat, 18 Aug 2012 23:44:29 -0700 [thread overview]
Message-ID: <20120819064429.GA3252@kroah.com> (raw)
In-Reply-To: <1345400832-23572-1-git-send-email-shijie8@gmail.com>
On Sun, Aug 19, 2012 at 02:27:12PM -0400, Huang Shijie wrote:
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -43,6 +43,7 @@
> #include <linux/tty_driver.h>
> #include <linux/tty_ldisc.h>
> #include <linux/mutex.h>
> +#include <linux/serial.h>
>
>
>
> @@ -513,6 +514,12 @@ static inline struct tty_port *tty_port_get(struct tty_port *port)
> return port;
> }
>
> +/* If the cts flow control is enabled, return true. */
> +static inline bool tty_port_cts_enabled(struct tty_port *port)
> +{
> + return port->flags & ASYNC_CTS_FLOW;
> +}
> +
The fact that you have to add serial.h to this file kind of implies that
this function shouldn't be here, right?
How about serial.h instead? Not all tty drivers are serial drivers :)
greg k-h
next prev parent reply other threads:[~2012-08-19 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 18:27 [PATCH] serial: add a new helper function Huang Shijie
2012-08-19 6:44 ` Greg KH [this message]
2012-08-19 7:00 ` Huang Shijie
2012-08-19 15:46 ` Alan Cox
2012-08-21 2:52 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120819064429.GA3252@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).