From: David Miller <davem@davemloft.net>
To: steve@shawell.net
Cc: bhutchings@solarflare.com, jimbob.betts@googlemail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 001/001] smsc95xx: Fix hard_header_len
Date: Mon, 20 Aug 2012 02:19:04 -0700 (PDT) [thread overview]
Message-ID: <20120820.021904.767463153826491601.davem@davemloft.net> (raw)
In-Reply-To: <CAKh2mn6fr8WjT-2h_A3zmKv3xs26AamXcpJgtK5wFPQ1BXuheg@mail.gmail.com>
From: Steve Glendinning <steve@shawell.net>
Date: Fri, 17 Aug 2012 09:35:04 +0100
>> hard_header_len is set to ETH_HLEN by alloc_etherdev() (in the
>> ether_setup() callback). Any extra headroom you want before the
>> Ethernet header should indeed be specified in needed_headroom.
>
> Thanks Ben, looks like this patch is doing it the right way then.
>
> Acked-By: Steve Glendinning <steve.glendinning@shawell.net>
This patch needs to be submitted with a proper signoff.
next prev parent reply other threads:[~2012-08-20 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 19:48 [PATCH 001/001] smsc95xx: Fix hard_header_len JamesBetts
2012-08-16 9:57 ` Steve Glendinning
2012-08-16 17:59 ` Ben Hutchings
2012-08-17 8:35 ` Steve Glendinning
2012-08-20 9:19 ` David Miller [this message]
2012-08-21 6:33 ` James Betts
2012-08-21 6:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820.021904.767463153826491601.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=jimbob.betts@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=steve@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).